This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Bearer JWT verify, auth/acl chaining, group/credential handling fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port Partial support for plugin chaining: allow skipping requests, where higher priority plugin has already set the credentials. The 'config.anomyous' approach to define "and/or" relationship between auth plugins is not utilized.
This way possible anonymous consumer identity set by higher priority plugin is cleared in case of OIDC authentiation. Makes it easier to use simultaneously for example basic-auth plugin, oidc plugin and acl plugin. This behavior is more in line with Kong-bundled auth plugins. There could be some upgrade impact, since previously the consumer identity was not touched and headers were not managed.
…er value Previously disable_userinfo_header impacted also setting of credential/group. This commit has some upgrade impact, if the previous behavior was relied upon.
Previously the parameter was not honored for token introspection case. This commit has some upgrade impact, if the previous behavior was relied upon.
|
👍 @cristichiru. I have a related proposal to the docker-kong-oidc Dockerfile to add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @cristichiru and all and thanks for your work with the OIDC plugin! This pull request has some patch proposals if you want to check and consider them:
For now for visibility these are all bundled in this single PR but as separate commits. If needed I could open them separately (but then some sequentially due to dependencies), but wanted to first hear your thoughts.
These are mostly backward compatible but there are some behavior changes due to the fixes/changes. Some notes could be compiled to docker-kong-oidc changelog if applying these. There is some info in individual commit messages.
Please have look and let know :)